correct copying of prefabs

engine/gamemap/mapgens/default.go

@@ -10,7 +10,7 @@ import (
 //fixme move to config
 var minRoomSize = 3
 var maxRoomSize = 22
-var maxrooms = 50
+var maxrooms = 20
 
 var fges = map[int]types.RectFill{
 	1: types.RectFill{
@@ -55,15 +55,18 @@ func DefaultGen(ctx util.ClientCtx,l *gamemap.Level) (*gamemap.Level, []*gamemap
 	}
 
 	rooms := make([]*gamemap.Room, 0)
-
+	prefabUsed := false
 	for i := 0; i < maxrooms; i++ {
 		failed := false
 		var fillage types.RectFill
 		fillage = fges[rng.GetWeightedEntity(map[int]int{1: 10, 2: 1})]
 		var newRoom *gamemap.Room
-		if rng.Range(0, 5) == 1 {
+		if !prefabUsed  || rng.Range(0,5) > 3 {
 			//prefab
-			newRoom = &pfRooms[0]
+			prefabUsed = true
+			r := pfRooms[rng.Range(0, len(pfRooms) - 1)] //copy to local scope
+			newRoom = &r
+
 		} else {
 			newRoom = gamemap.NewRandomRectRoom(
 				rng,